Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e0dd741 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Linus Torvalds
Browse files

[PATCH] sysfs: zero terminate sysfs write buffers 



No one should be writing a PAGE_SIZE worth of data to a normal sysfs
file, so properly terminate the buffer.

Thanks to Al Viro for pointing out my supidity here.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 597a7679

fs/sysfs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ fill_write_buffer(struct sysfs_buffer * buffer, const char __user * buf, size_t 
		return -ENOMEM;



	if (count >= PAGE_SIZE)

		count = PAGE_SIZE;

		count = PAGE_SIZE - 1;

	error = copy_from_user(buffer->page,buf,count);

	buffer->needs_read_fill = 1;

	return error ? -EFAULT : count;