Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6da33dbd authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij
Browse files

pinctrl: abx500: fix bitwise AND test 



The intent here was to test if the bit was set or not but there is a
logical vs bitwise AND typo so it is true if any bits are set.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a8a364bd

drivers/pinctrl/pinctrl-abx500.c

+3 −3
Original line number Diff line number Diff line
@@ -426,7 +426,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, struct gpio_chip *chip, 
				ret = abx500_gpio_set_bits(chip,

					AB8500_GPIO_ALTFUN_REG,

					af.alt_bit2,

					!!(af.alta_val && BIT(1)));

					!!(af.alta_val & BIT(1)));

		} else

			ret = abx500_gpio_set_bits(chip, AB8500_GPIO_SEL1_REG,

					offset, 1);
@@ -447,7 +447,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, struct gpio_chip *chip, 
			ret = abx500_gpio_set_bits(chip,

					AB8500_GPIO_ALTFUN_REG,

					af.alt_bit2,

					!!(af.altb_val && BIT(1)));

					!!(af.altb_val & BIT(1)));

		break;



	case ABX500_ALT_C:
@@ -457,7 +457,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, struct gpio_chip *chip, 
			goto out;



		ret = abx500_gpio_set_bits(chip, AB8500_GPIO_ALTFUN_REG,

				af.alt_bit2, !!(af.altc_val && BIT(0)));

				af.alt_bit2, !!(af.altc_val & BIT(0)));

		if (ret < 0)

			goto out;