Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6da025fa authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv4: avoid a test in ip_rt_put() 



We can save a test in ip_rt_put(), considering dst_release() accepts
a NULL parameter, and dst is first element in rtable.

Add a BUILD_BUG_ON() to catch any change that could break this
assertion.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Cong Wang <amwang@redhat.com>
Acked-by: default avatarCong Wang <amwang@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b26ddd81

include/net/route.h

+6 −3
Original line number Diff line number Diff line
@@ -200,7 +200,10 @@ extern void fib_del_ifaddr(struct in_ifaddr *, struct in_ifaddr *); 


static inline void ip_rt_put(struct rtable *rt)

{

	if (rt)

	/* dst_release() accepts a NULL parameter.

	 * We rely on dst being first structure in struct rtable

	 */

	BUILD_BUG_ON(offsetof(struct rtable, dst) != 0);

	dst_release(&rt->dst);

}