Commit 6d994a7e authored Nov 02, 2011 by Rakib Mullick Committed by Linus Torvalds Nov 02, 2011

drivers/misc/vmw_balloon.c: determine page allocation flag can_sleep outside loop



In vmballoon_reserve_page(), flags has been passed from the callee
function (vmballoon_inflate here).  So, we can determine can_sleep outside
the loop.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Acked-by: Dmitry Torokhov <dtor@vmware.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3fd306c8

drivers/misc/vmw_balloon.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -412,6 +412,7 @@ static int vmballoon_reserve_page(struct vmballoon *b, bool can_sleep)
		gfp_t flags;
		unsigned int hv_status;
		bool locked = false;
		flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP : VMW_PAGE_ALLOC_NOSLEEP;

		do {
		if (!can_sleep)
		@@ -419,7 +420,6 @@ static int vmballoon_reserve_page(struct vmballoon *b, bool can_sleep)
		else
		STATS_INC(b->stats.sleep_alloc);

		flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP : VMW_PAGE_ALLOC_NOSLEEP;
		page = alloc_page(flags);
		if (!page) {
		if (!can_sleep)