Commit 6d3e0d0c authored Sep 04, 2013 by Tomas Winkler Committed by Greg Kroah-Hartman Sep 26, 2013

hpet: remove useless check if fixmem32 is NULL



fixmem32 is assigned to address of res->data member
so the address is always valid

Actually since we are not checking for res != NULL
static analyzing is complaining about referencing the pointer
and consequent check for null.
The code snippet looks confusing also for human eyes.

Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d396034a

drivers/char/hpet.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -971,8 +971,6 @@ static acpi_status hpet_resources(struct acpi_resource res, void data)
		struct acpi_resource_fixed_memory32 *fixmem32;

		fixmem32 = &res->data.fixed_memory32;
		if (!fixmem32)
		return AE_NO_MEMORY;

		hdp->hd_phys_address = fixmem32->address;
		hdp->hd_address = ioremap(fixmem32->address,