Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c3a30c7 authored by Felipe Balbi's avatar Felipe Balbi Committed by Greg Kroah-Hartman
Browse files

serial: omap: don't save IRQ flags on hardirq 



When we're running our hardirq handler, there's
not need to disable IRQs with spin_lock_irqsave()
because IRQs are already disabled. It also makes
no difference if we save or not IRQ flags.

Switch over to simple spin_lock/spin_unlock and
drop the "flags" variable.

Tested-by: default avatarShubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7e9c8e7d

drivers/tty/serial/omap-serial.c

+2 −3
Original line number Diff line number Diff line
@@ -351,11 +351,10 @@ static inline irqreturn_t serial_omap_irq(int irq, void *dev_id) 
	struct tty_struct *tty = up->port.state->port.tty;

	unsigned int iir, lsr;

	unsigned int type;

	unsigned long flags;

	irqreturn_t ret = IRQ_NONE;

	int max_count = 256;



	spin_lock_irqsave(&up->port.lock, flags);

	spin_lock(&up->port.lock);

	pm_runtime_get_sync(up->dev);



	do {
@@ -394,7 +393,7 @@ static inline irqreturn_t serial_omap_irq(int irq, void *dev_id) 
		}

	} while (!(iir & UART_IIR_NO_INT) && max_count--);



	spin_unlock_irqrestore(&up->port.lock, flags);

	spin_unlock(&up->port.lock);



	tty_flip_buffer_push(tty);