Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6aa054aa authored by Tejun Heo's avatar Tejun Heo Committed by Greg Kroah-Hartman
Browse files

sysfs: fix condition check in sysfs_drop_dentry() 



The condition check doesn't make much sense as it basically always
succeeds.  This causes NULL dereferencing on certain cases.  It seems
that parentheses are put in the wrong place.  Fix it.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent dc351252

fs/sysfs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) 
	if (dentry) {

		spin_lock(&dcache_lock);

		spin_lock(&dentry->d_lock);

		if (!(d_unhashed(dentry) && dentry->d_inode)) {

		if (!d_unhashed(dentry) && dentry->d_inode) {

			inode = dentry->d_inode;

			spin_lock(&inode->i_lock);

			__iget(inode);