Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68a1750b authored by Joe Eykholt's avatar Joe Eykholt Committed by James Bottomley
Browse files

[SCSI] libfc: LOGO response code had extraeous enter_rtv 



fc_rport_logo_resp() had a call to fc_rport_enter_rtv() if the
LOGO was accepted.  This must've been a copy/paste mistake, but
it didn't matter since we don't stay in the LOGO state long enough
to hit this code.

Change fc_rport_logo_resp() to just enter the delete state
no matter what.

Signed-off-by: default avatarJoe Eykholt <jeykholt@cisco.com>
Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent feab4ae7

drivers/scsi/libfc/fc_rport.c

+4 −6
Original line number Diff line number Diff line
@@ -725,12 +725,10 @@ static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp, 
	}



	op = fc_frame_payload_op(fp);

	if (op == ELS_LS_ACC) {

		fc_rport_enter_rtv(rdata);

	} else {

		FC_RPORT_DBG(rdata, "Bad ELS response for LOGO command\n");

	if (op != ELS_LS_ACC)

		FC_RPORT_DBG(rdata, "Bad ELS response op %x for LOGO command\n",

			     op);

	fc_rport_enter_delete(rdata, RPORT_EV_LOGO);

	}



out:

	fc_frame_free(fp);