Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 683e7cdc authored by Julia Lawall's avatar Julia Lawall Committed by Paul Mundt
Browse files

drivers/video: Convert release_resource to release_mem_region 

Request_mem_region should be used with release_mem_region, not
release_resource.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@s exists@
expression e1,e2,e3,e4,e;
@@

*e4 = request_mem_region(e1,e2,e3)
... when != e4 = e
*release_resource(e4);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 94cd1ae2

drivers/video/s3c-fb.c

+2 −4
Original line number Diff line number Diff line
@@ -1449,8 +1449,7 @@ err_ioremap: 
	iounmap(sfb->regs);



err_req_region:

	release_resource(sfb->regs_res);

	kfree(sfb->regs_res);

	release_mem_region(sfb->regs_res->start, resource_size(sfb->regs_res));



err_clk:

	clk_disable(sfb->bus_clk);
@@ -1486,8 +1485,7 @@ static int __devexit s3c_fb_remove(struct platform_device *pdev) 
	clk_disable(sfb->bus_clk);

	clk_put(sfb->bus_clk);



	release_resource(sfb->regs_res);

	kfree(sfb->regs_res);

	release_mem_region(sfb->regs_res->start, resource_size(sfb->regs_res));



	kfree(sfb);

drivers/video/sh7760fb.c

+2 −4
Original line number Diff line number Diff line
@@ -551,8 +551,7 @@ out_unmap: 
		free_irq(par->irq, &par->vsync);

	iounmap(par->base);

out_res:

	release_resource(par->ioarea);

	kfree(par->ioarea);

	release_mem_region(res->start, resource_size(res));

out_fb:

	framebuffer_release(info);

	return ret;
@@ -570,8 +569,7 @@ static int __devexit sh7760fb_remove(struct platform_device *dev) 
	if (par->irq >= 0)

		free_irq(par->irq, par);

	iounmap(par->base);

	release_resource(par->ioarea);

	kfree(par->ioarea);

	release_mem_region(par->ioarea->start, resource_size(par->ioarea));

	framebuffer_release(info);

	platform_set_drvdata(dev, NULL);