Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67453911 authored by Nick Piggin's avatar Nick Piggin Committed by Linus Torvalds
Browse files

[PATCH] mm: less atomic ops 



In the page release paths, we can be sure that nobody will mess with our
page->flags because the refcount has dropped to 0.  So no need for atomic
operations here.

Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 4c84cacf

include/linux/mm_inline.h

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ del_page_from_lru(struct zone *zone, struct page *page) 
{

	list_del(&page->lru);

	if (PageActive(page)) {

		ClearPageActive(page);

		__ClearPageActive(page);

		zone->nr_active--;

	} else {

		zone->nr_inactive--;

include/linux/page-flags.h

+2 −0
Original line number Diff line number Diff line
@@ -242,10 +242,12 @@ extern void __mod_page_state_offset(unsigned long offset, unsigned long delta); 
#define PageLRU(page)		test_bit(PG_lru, &(page)->flags)

#define SetPageLRU(page)	set_bit(PG_lru, &(page)->flags)

#define ClearPageLRU(page)	clear_bit(PG_lru, &(page)->flags)

#define __ClearPageLRU(page)	__clear_bit(PG_lru, &(page)->flags)



#define PageActive(page)	test_bit(PG_active, &(page)->flags)

#define SetPageActive(page)	set_bit(PG_active, &(page)->flags)

#define ClearPageActive(page)	clear_bit(PG_active, &(page)->flags)

#define __ClearPageActive(page)	__clear_bit(PG_active, &(page)->flags)



#define PageSlab(page)		test_bit(PG_slab, &(page)->flags)

#define SetPageSlab(page)	set_bit(PG_slab, &(page)->flags)

mm/swap.c

+2 −2
Original line number Diff line number Diff line
@@ -215,7 +215,7 @@ void fastcall __page_cache_release(struct page *page) 


		spin_lock_irqsave(&zone->lru_lock, flags);

		BUG_ON(!PageLRU(page));

		ClearPageLRU(page);

		__ClearPageLRU(page);

		del_page_from_lru(zone, page);

		spin_unlock_irqrestore(&zone->lru_lock, flags);

	}
@@ -266,7 +266,7 @@ void release_pages(struct page **pages, int nr, int cold) 
				spin_lock_irq(&zone->lru_lock);

			}

			BUG_ON(!PageLRU(page));

			ClearPageLRU(page);

			__ClearPageLRU(page);

			del_page_from_lru(zone, page);

		}