Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66a77072 authored by Meenakshi Venkataraman's avatar Meenakshi Venkataraman Committed by John W. Linville
Browse files

iwlwifi: do not use shadow registers by default 



Shadow registers in the device are meant to
allow the driver to update certain device
registers without needing to wake up all
components of the device. However, using
this feature in the device causes
communication between the driver and the
device to become unreliable, resulting in
host command timeouts.

Disable this feature by default till a fix is
available for the bug.

Cc: stable@vger.kernel.org #2.6.38+
Signed-off-by: default avatarMeenakshi Venkataraman <meenakshi.venkataraman@intel.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent ebed633c

drivers/net/wireless/iwlwifi/iwl-2000.c

+2 −2
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ static const struct iwl_base_params iwl2000_base_params = { 
	.chain_noise_scale = 1000,

	.wd_timeout = IWL_DEF_WD_TIMEOUT,

	.max_event_log_size = 512,

	.shadow_reg_enable = true,

	.shadow_reg_enable = false, /* TODO: fix bugs using this feature */

	.hd_v2 = true,

};
@@ -97,7 +97,7 @@ static const struct iwl_base_params iwl2030_base_params = { 
	.chain_noise_scale = 1000,

	.wd_timeout = IWL_LONG_WD_TIMEOUT,

	.max_event_log_size = 512,

	.shadow_reg_enable = true,

	.shadow_reg_enable = false, /* TODO: fix bugs using this feature */

	.hd_v2 = true,

};

drivers/net/wireless/iwlwifi/iwl-6000.c

+3 −3
Original line number Diff line number Diff line
@@ -86,7 +86,7 @@ static const struct iwl_base_params iwl6000_base_params = { 
	.chain_noise_scale = 1000,

	.wd_timeout = IWL_DEF_WD_TIMEOUT,

	.max_event_log_size = 512,

	.shadow_reg_enable = true,

	.shadow_reg_enable = false, /* TODO: fix bugs using this feature */

};



static const struct iwl_base_params iwl6050_base_params = {
@@ -102,7 +102,7 @@ static const struct iwl_base_params iwl6050_base_params = { 
	.chain_noise_scale = 1500,

	.wd_timeout = IWL_DEF_WD_TIMEOUT,

	.max_event_log_size = 1024,

	.shadow_reg_enable = true,

	.shadow_reg_enable = false, /* TODO: fix bugs using this feature */

};



static const struct iwl_base_params iwl6000_g2_base_params = {
@@ -118,7 +118,7 @@ static const struct iwl_base_params iwl6000_g2_base_params = { 
	.chain_noise_scale = 1000,

	.wd_timeout = IWL_LONG_WD_TIMEOUT,

	.max_event_log_size = 512,

	.shadow_reg_enable = true,

	.shadow_reg_enable = false, /* TODO: fix bugs using this feature */

};



static const struct iwl_ht_params iwl6000_ht_params = {