Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 661eb381 authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: fix TX aggregation TID struct leak 



Ben reports that kmemleak is saying TX aggregation TID
structs are leaked. Given his workload, I suspect that
they're leaked because stations are destroyed before
their aggregation sessions get a chance to start. Fix
this by simply freeing structs that are not used yet.

Reported-by: default avatarBen Greear <greearb@candelatech.com>
Tested-by: default avatarBen Greear <greearb@candelatech.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 940d0ac9

net/mac80211/sta_info.c

+1 −0
Original line number Diff line number Diff line
@@ -149,6 +149,7 @@ static void cleanup_single_sta(struct sta_info *sta) 
	 * directly by station destruction.

	 */

	for (i = 0; i < IEEE80211_NUM_TIDS; i++) {

		kfree(sta->ampdu_mlme.tid_start_tx[i]);

		tid_tx = rcu_dereference_raw(sta->ampdu_mlme.tid_tx[i]);

		if (!tid_tx)

			continue;