Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6619a53e authored by Andi Kleen's avatar Andi Kleen Committed by Arnaldo Carvalho de Melo
Browse files

perf record: Add --initial-delay option 



perf stat has a --delay option to delay measuring the workload.

This is useful to skip measuring the startup phase of the program, which
is often very different from the main workload.

The same is useful for perf record when sampling.

--no-delay was already taken, so add a --initial-delay
to perf record too.
-D was already taken for record, so there is only a long option.

v2: Don't disable group members (Namhyung Kim)
v3: port to latest perf/core
    rename to --initial-delay to avoid conflict with --no-delay

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1389476307-2124-1-git-send-email-andi@firstfloor.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent d11416e7

tools/perf/Documentation/perf-record.txt

+4 −0
Original line number Diff line number Diff line
@@ -209,6 +209,10 @@ overrides that and uses per-thread mmaps. A side-effect of that is that 
inheritance is automatically disabled.  --per-thread is ignored with a warning

if combined with -a or -C options.



--initial-delay msecs::

After starting the program, wait msecs before measuring. This is useful to

filter out the startup phase of the program, which is often very different.



SEE ALSO

--------

linkperf:perf-stat[1], linkperf:perf-list[1]

tools/perf/builtin-record.c

+8 −1
Original line number Diff line number Diff line
@@ -499,7 +499,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) 
	 * (apart from group members) have enable_on_exec=1 set,

	 * so don't spoil it by prematurely enabling them.

	 */

	if (!target__none(&opts->target))

	if (!target__none(&opts->target) && !opts->initial_delay)

		perf_evlist__enable(rec->evlist);



	/*
@@ -508,6 +508,11 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) 
	if (forks)

		perf_evlist__start_workload(rec->evlist);



	if (opts->initial_delay) {

		usleep(opts->initial_delay * 1000);

		perf_evlist__enable(rec->evlist);

	}



	for (;;) {

		int hits = rec->samples;
@@ -877,6 +882,8 @@ const struct option record_options[] = { 
	OPT_CALLBACK('G', "cgroup", &record.evlist, "name",

		     "monitor event in cgroup name only",

		     parse_cgroups),

	OPT_UINTEGER(0, "initial-delay", &record.opts.initial_delay,

		  "ms to wait before starting measurement after program start"),

	OPT_STRING('u', "uid", &record.opts.target.uid_str, "user",

		   "user to profile"),

tools/perf/perf.h

+1 −0
Original line number Diff line number Diff line
@@ -269,6 +269,7 @@ struct record_opts { 
	u64	     user_interval;

	u16	     stack_dump_size;

	bool	     sample_transaction;

	unsigned     initial_delay;

};



#endif

tools/perf/util/evsel.c

+2 −1
Original line number Diff line number Diff line
@@ -658,7 +658,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) 
	 * Setting enable_on_exec for independent events and

	 * group leaders for traced executed by perf.

	 */

	if (target__none(&opts->target) && perf_evsel__is_group_leader(evsel))

	if (target__none(&opts->target) && perf_evsel__is_group_leader(evsel) &&

		!opts->initial_delay)

		attr->enable_on_exec = 1;

}