Commit 65ec1f1d authored Jun 29, 2018 by Nicholas Mc Guire Committed by Greg Kroah-Hartman Oct 13, 2018

ALSA: snd-aoa: add of_node_put() in error path



[ Upstream commit 222bce5eb88d1af656419db04bcd84b2419fb900 ]

 Both calls to of_find_node_by_name() and of_get_next_child() return a
node pointer with refcount incremented thus it must be explicidly
decremented here after the last usage. As we are assured to have a
refcounted  np  either from the initial
of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np)
in the while loop if we reached the error code path below, an
x of_node_put(np) is needed.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: commit f3d9478b ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8963aa53

sound/aoa/core/gpio-feature.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -88,8 +88,10 @@ static struct device_node get_gpio(char name,
		}

		reg = of_get_property(np, "reg", NULL);
		if (!reg)
		if (!reg) {
		of_node_put(np);
		return NULL;
		}

		gpioptr = reg;