Commit 65e2f1cb authored Nov 02, 2013 by Mauro Carvalho Chehab

[media] af9015: Don't use dynamic static allocation



Dynamic static allocation is evil, as Kernel stack is too low, and
compilation complains about it on some archs:
	drivers/media/usb/dvb-usb-v2/af9015.c:433:1: warning: 'af9015_eeprom_hash' uses dynamic stack allocation [enabled by default]
In this specific case, it is a gcc bug, as the size is a const, but
it is easy to just change it from const to a #define, getting rid of
the gcc warning.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent 0065a79a

drivers/media/usb/dvb-usb-v2/af9015.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -397,12 +397,13 @@ error:
		return ret;
		}

		#define AF9015_EEPROM_SIZE 256

		/* hash (and dump) eeprom */
		static int af9015_eeprom_hash(struct dvb_usb_device *d)
		{
		struct af9015_state *state = d_to_priv(d);
		int ret, i;
		static const unsigned int AF9015_EEPROM_SIZE = 256;
		u8 buf[AF9015_EEPROM_SIZE];
		struct req_t req = {READ_I2C, AF9015_I2C_EEPROM, 0, 0, 1, 1, NULL};