Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65b302ad authored by Christoph Jaeger's avatar Christoph Jaeger Committed by Roland Dreier
Browse files

RDMA/cxgb4: Fix memory leaks in c4iw_alloc() error paths 



c4iw_alloc() bails out without freeing the storage that 'devp' points to.

Picked up by Coverity - CID 1204241.

Fixes: fa658a98 ("RDMA/cxgb4: Use the BAR2/WC path for kernel QPs and T5 devices")
Signed-off-by: default avatarChristoph Jaeger <christophjaeger@linux.com>
Acked-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent d6d211db

drivers/infiniband/hw/cxgb4/device.c

+2 −0
Original line number Diff line number Diff line
@@ -736,6 +736,7 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop) 
			pci_resource_len(devp->rdev.lldi.pdev, 2));

		if (!devp->rdev.bar2_kva) {

			pr_err(MOD "Unable to ioremap BAR2\n");

			ib_dealloc_device(&devp->ibdev);

			return ERR_PTR(-EINVAL);

		}

	} else if (ocqp_supported(infop)) {
@@ -747,6 +748,7 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop) 
			devp->rdev.lldi.vr->ocq.size);

		if (!devp->rdev.oc_mw_kva) {

			pr_err(MOD "Unable to ioremap onchip mem\n");

			ib_dealloc_device(&devp->ibdev);

			return ERR_PTR(-EINVAL);

		}

	}