Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6588208c authored by Jingoo Han's avatar Jingoo Han Committed by Linus Torvalds
Browse files

rtc: rtc-at91rm9200: use dev_dbg()/dev_err() instead of printk()/pr_debug() 



Fix the checkpatch warning as below:

  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0c6516ea

drivers/rtc/rtc-at91rm9200.c

+8 −9
Original line number Original line Diff line number Diff line
@@ -86,7 +86,7 @@ static int at91_rtc_readtime(struct device *dev, struct rtc_time *tm) 
	tm->tm_yday = rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year);

	tm->tm_yday = rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year);

	tm->tm_year = tm->tm_year - 1900;

	tm->tm_year = tm->tm_year - 1900;





	pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

	dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,

		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,

		tm->tm_hour, tm->tm_min, tm->tm_sec);

		tm->tm_hour, tm->tm_min, tm->tm_sec);
@@ -100,7 +100,7 @@ static int at91_rtc_settime(struct device *dev, struct rtc_time *tm) 
{

{

	unsigned long cr;

	unsigned long cr;





	pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

	dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,

		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,

		tm->tm_hour, tm->tm_min, tm->tm_sec);

		tm->tm_hour, tm->tm_min, tm->tm_sec);
@@ -145,7 +145,7 @@ static int at91_rtc_readalarm(struct device *dev, struct rtc_wkalrm *alrm) 
	alrm->enabled = (at91_rtc_read(AT91_RTC_IMR) & AT91_RTC_ALARM)

	alrm->enabled = (at91_rtc_read(AT91_RTC_IMR) & AT91_RTC_ALARM)

			? 1 : 0;

			? 1 : 0;





	pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

	dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,

		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,

		tm->tm_hour, tm->tm_min, tm->tm_sec);

		tm->tm_hour, tm->tm_min, tm->tm_sec);
@@ -183,7 +183,7 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) 
		at91_rtc_write(AT91_RTC_IER, AT91_RTC_ALARM);

		at91_rtc_write(AT91_RTC_IER, AT91_RTC_ALARM);

	}

	}





	pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

	dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__,

		at91_alarm_year, tm.tm_mon, tm.tm_mday, tm.tm_hour,

		at91_alarm_year, tm.tm_mon, tm.tm_mday, tm.tm_hour,

		tm.tm_min, tm.tm_sec);

		tm.tm_min, tm.tm_sec);
@@ -192,7 +192,7 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) 




static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)

static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)

{

{

	pr_debug("%s(): cmd=%08x\n", __func__, enabled);

	dev_dbg(dev, "%s(): cmd=%08x\n", __func__, enabled);





	if (enabled) {

	if (enabled) {

		at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);

		at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
@@ -240,7 +240,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id) 




		rtc_update_irq(rtc, 1, events);

		rtc_update_irq(rtc, 1, events);





		pr_debug("%s(): num=%ld, events=0x%02lx\n", __func__,

		dev_dbg(&pdev->dev, "%s(): num=%ld, events=0x%02lx\n", __func__,

			events >> 8, events & 0x000000FF);

			events >> 8, events & 0x000000FF);





		return IRQ_HANDLED;

		return IRQ_HANDLED;
@@ -296,8 +296,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) 
				IRQF_SHARED,

				IRQF_SHARED,

				"at91_rtc", pdev);

				"at91_rtc", pdev);

	if (ret) {

	if (ret) {

		printk(KERN_ERR "at91_rtc: IRQ %d already in use.\n",

		dev_err(&pdev->dev, "IRQ %d already in use.\n", irq);

				irq);

		return ret;

		return ret;

	}

	}
@@ -315,7 +314,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) 
	}

	}

	platform_set_drvdata(pdev, rtc);

	platform_set_drvdata(pdev, rtc);





	printk(KERN_INFO "AT91 Real Time Clock driver.\n");

	dev_info(&pdev->dev, "AT91 Real Time Clock driver.\n");

	return 0;

	return 0;

}

}