Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 654c35ab authored by Kuninori Morimoto's avatar Kuninori Morimoto Committed by Felipe Balbi
Browse files

usb: gadget: renesas_usbhs: disable auto paket start on usbhs_pkt_push() 



Automatically packet start by usbhs_pkt_push() was useful.
But the pushed packet will be called twice
if new packet was pushed on usbhs_pkt :: done callback.
(1st is called by usbhs_pkt_push(), 2nd is called by usbhsf_pkt_handler())

This patch disables automatic packet start,
and clarified packet start timing.

Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent b331872b

drivers/usb/renesas_usbhs/fifo.c

+0 −2
Original line number Diff line number Diff line
@@ -93,8 +93,6 @@ void usbhs_pkt_push(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt, 


	usbhs_unlock(priv, flags);

	/********************  spin unlock ******************/



	usbhs_pkt_start(pipe);

}



static void __usbhsf_pkt_del(struct usbhs_pkt *pkt)

drivers/usb/renesas_usbhs/mod_gadget.c

+1 −0
Original line number Diff line number Diff line
@@ -165,6 +165,7 @@ static void usbhsg_queue_push(struct usbhsg_uep *uep, 
	req->status = -EINPROGRESS;

	usbhs_pkt_push(pipe, pkt, usbhsg_queue_done,

		       req->buf, req->length, req->zero);

	usbhs_pkt_start(pipe);



	dev_dbg(dev, "pipe %d : queue push (%d)\n",

		usbhs_pipe_number(pipe),