Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 654484aa authored by Dan Carpenter's avatar Dan Carpenter Committed by Sasha Levin
Browse files

mptfusion: prevent some memory corruption 



[ Upstream commit e819cdb198319cccf4af4fc12ac4d796109d8c23 ]

These are signed values the come from the user, we put a cap on the
upper bounds but not on the lower bounds.

We use "karg.dataSgeOffset" to calculate "sz".  We verify "sz" and
proceed as if that means that "karg.dataSgeOffset" is correct but this
fails to consider that the "sz" calculations can have integer overflows.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
parent 7bb11a7b

drivers/message/fusion/mptctl.c

+9 −0
Original line number Diff line number Diff line
@@ -1859,6 +1859,15 @@ mptctl_do_mpt_command (struct mpt_ioctl_command karg, void __user *mfPtr) 
	}

	spin_unlock_irqrestore(&ioc->taskmgmt_lock, flags);



	/* Basic sanity checks to prevent underflows or integer overflows */

	if (karg.maxReplyBytes < 0 ||

	    karg.dataInSize < 0 ||

	    karg.dataOutSize < 0 ||

	    karg.dataSgeOffset < 0 ||

	    karg.maxSenseBytes < 0 ||

	    karg.dataSgeOffset > ioc->req_sz / 4)

		return -EINVAL;



	/* Verify that the final request frame will not be too large.

	 */

	sz = karg.dataSgeOffset * 4;