Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 64905b48 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

USB: ftdi_sio: unlock_kernel() on error in set_serial_info() 

There was one error path where unlock_kernel() wasn't called.

This was found with a code checker (http://repo.or.cz/w/smatch.git/

)
Compile tested only, sorry.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 506e9469

drivers/usb/serial/ftdi_sio.c

+3 −1
Original line number Diff line number Diff line
@@ -1065,8 +1065,10 @@ static int set_serial_info(struct tty_struct *tty, 


	if (!capable(CAP_SYS_ADMIN)) {

		if (((new_serial.flags & ~ASYNC_USR_MASK) !=

		     (priv->flags & ~ASYNC_USR_MASK)))

		     (priv->flags & ~ASYNC_USR_MASK))) {

			unlock_kernel();

			return -EPERM;

		}

		priv->flags = ((priv->flags & ~ASYNC_USR_MASK) |

			       (new_serial.flags & ASYNC_USR_MASK));

		priv->custom_divisor = new_serial.custom_divisor;