Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63ec9868 authored by Herbert Xu's avatar Herbert Xu Committed by Greg Kroah-Hartman
Browse files

xfrm: Copy policy family in clone_policy 




[ Upstream commit 0e74aa1d79a5bbc663e03a2804399cae418a0321 ]

The syzbot found an ancient bug in the IPsec code.  When we cloned
a socket policy (for example, for a child TCP socket derived from a
listening socket), we did not copy the family field.  This results
in a live policy with a zero family field.  This triggers a BUG_ON
check in the af_key code when the cloned policy is retrieved.

This patch fixes it by copying the family field over.

Reported-by: default avatarsyzbot <syzkaller@googlegroups.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d22443f3

net/xfrm/xfrm_policy.c

+1 −0
Original line number Diff line number Diff line
@@ -1345,6 +1345,7 @@ static struct xfrm_policy *clone_policy(const struct xfrm_policy *old, int dir) 
		newp->xfrm_nr = old->xfrm_nr;

		newp->index = old->index;

		newp->type = old->type;

		newp->family = old->family;

		memcpy(newp->xfrm_vec, old->xfrm_vec,

		       newp->xfrm_nr*sizeof(struct xfrm_tmpl));

		write_lock_bh(&net->xfrm.xfrm_policy_lock);