Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6398d424 authored by Jerome Glisse's avatar Jerome Glisse Committed by Dave Airlie
Browse files

drm/radeon/kms: Do not unpin buffer in fb destruction 



It's not necessary to unpin buffer in fb destruction. pin/unpin
need to be balanced and we don't pin in fb creation. We pin when
an fb is associated to a crtc and unpin when the fb is disassociated
from the crtc.

Note:
Maybe we should take reference on fb in set_base callback so fb
doesn't disappear until it's unbind from ctrc.

Signed-off-by: default avatarJerome Glisse <jglisse@redhat.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 7a15cbd4

drivers/gpu/drm/radeon/radeon_display.c

+0 −1
Original line number Diff line number Diff line
@@ -668,7 +668,6 @@ static void radeon_user_framebuffer_destroy(struct drm_framebuffer *fb) 
		radeonfb_remove(dev, fb);



	if (radeon_fb->obj) {

		radeon_gem_object_unpin(radeon_fb->obj);

		mutex_lock(&dev->struct_mutex);

		drm_gem_object_unreference(radeon_fb->obj);

		mutex_unlock(&dev->struct_mutex);