Commit 634608f2 authored Jan 07, 2014 by Wei Yongjun Committed by Greg Kroah-Hartman Jan 08, 2014

misc: genwqe: fix return value check in genwqe_device_create()



In case of error, the function device_create_with_groups()
returns ERR_PTR() and never returns NULL. The NULL test in
the return value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3c1547e7

drivers/misc/genwqe/card_dev.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1306,8 +1306,8 @@ int genwqe_device_create(struct genwqe_dev *cd)
		genwqe_attribute_groups,
		GENWQE_DEVNAME "%u_card",
		cd->card_idx);
		if (cd->dev == NULL) {
		rc = -ENODEV;
		if (IS_ERR(cd->dev)) {
		rc = PTR_ERR(cd->dev);
		goto err_cdev;
		}