Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63002e84 authored by Guenter Roeck's avatar Guenter Roeck Committed by Mark Brown
Browse files

spi/topcliff-pch: Fix device remove function 



The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is complete; it reduces the device reference count to zero, which results in
device memory being freed. An extra call to spi_master_put is unnecessary
and results in an access to free memory. Drop it.

Also, the device subsystem resets device driver data to NULL after the call to
the remove function returns, so there is no need to do it here.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent c68025bf

drivers/spi/spi-topcliff-pch.c

+0 −2
Original line number Diff line number Diff line
@@ -1536,8 +1536,6 @@ static int __devexit pch_spi_pd_remove(struct platform_device *plat_dev) 


	pci_iounmap(board_dat->pdev, data->io_remap_addr);

	spi_unregister_master(data->master);

	spi_master_put(data->master);

	platform_set_drvdata(plat_dev, NULL);



	return 0;

}