Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62da659a authored by Roel Kluin's avatar Roel Kluin Committed by Linus Torvalds
Browse files

rtc-wm8350: retries will reach -1 



With a postfix decrement retries will reach -1 rather than 0, so the
warning and error-out will not occur.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a2166858

drivers/rtc/rtc-wm8350.c

+2 −2
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ static int wm8350_rtc_settime(struct device *dev, struct rtc_time *tm) 
	do {

		rtc_ctrl = wm8350_reg_read(wm8350, WM8350_RTC_TIME_CONTROL);

		schedule_timeout_uninterruptible(msecs_to_jiffies(1));

	} while (retries-- && !(rtc_ctrl & WM8350_RTC_STS));

	} while (--retries && !(rtc_ctrl & WM8350_RTC_STS));



	if (!retries) {

		dev_err(dev, "timed out on set confirmation\n");
@@ -437,7 +437,7 @@ static int wm8350_rtc_probe(struct platform_device *pdev) 
		do {

			timectl = wm8350_reg_read(wm8350,

						  WM8350_RTC_TIME_CONTROL);

		} while (timectl & WM8350_RTC_STS && retries--);

		} while (timectl & WM8350_RTC_STS && --retries);



		if (retries == 0) {

			dev_err(&pdev->dev, "failed to start: timeout\n");