Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62b807f6 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf evsel: No need to always ask for PERF_FORMAT_TOTAL_TIME_{ENABLED,RUNNING} 

This is needed, so far, just in 'perf stat', to scale counters, so don't
unconditionally ask for them in the perf_evsel__config() method.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-ujpujgscq2f2oodxuso5nobc@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 3a5afaec

tools/perf/tests/attr/base-record

+1 −1
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ size=96 
config=0

sample_period=4000

sample_type=263

read_format=3

read_format=0

disabled=1

inherit=1

pinned=0

tools/perf/tests/attr/test-record-group

+2 −2
Original line number Diff line number Diff line
@@ -6,14 +6,14 @@ args = --group -e cycles,instructions kill >/dev/null 2>&1 
fd=1

group_fd=-1

sample_type=327

read_format=7

read_format=4



[event-2:base-record]

fd=2

group_fd=1

config=1

sample_type=327

read_format=7

read_format=4

mmap=0

comm=0

enable_on_exec=0

tools/perf/tests/attr/test-record-group1

+2 −2
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ args = -e '{cycles,instructions}' kill >/tmp/krava 2>&1 
fd=1

group_fd=-1

sample_type=327

read_format=7

read_format=4



[event-2:base-record]

fd=2
@@ -14,7 +14,7 @@ group_fd=1 
type=0

config=1

sample_type=327

read_format=7

read_format=4

mmap=0

comm=0

enable_on_exec=0

tools/perf/util/evsel.c

+0 −2
Original line number Diff line number Diff line
@@ -465,8 +465,6 @@ void perf_evsel__config(struct perf_evsel *evsel, 


	attr->sample_id_all = opts->sample_id_all_missing ? 0 : 1;

	attr->inherit	    = !opts->no_inherit;

	attr->read_format   = PERF_FORMAT_TOTAL_TIME_ENABLED |

			      PERF_FORMAT_TOTAL_TIME_RUNNING;



	perf_evsel__set_sample_bit(evsel, IP);

	perf_evsel__set_sample_bit(evsel, TID);