Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6201573c authored by Jean Delvare's avatar Jean Delvare Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (3568f): saa7110: Fix array overrun 



Fix a (probably harmless) array overrun in the DECODER_DUMP command of the
saa7110 driver.  No big deal as this command is not used anywhere anyway. 
Also reformat the dump so that it displays nicely.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent f49a5eae

drivers/media/video/saa7110.c

+5 −7
Original line number Diff line number Diff line
@@ -432,15 +432,13 @@ saa7110_command (struct i2c_client *client, 
		break;



	case DECODER_DUMP:

		for (v = 0; v < 0x34; v += 16) {

		for (v = 0; v < SAA7110_NR_REG; v += 16) {

			int j;

			dprintk(1, KERN_INFO "%s: %03x\n", I2C_NAME(client),

			dprintk(1, KERN_DEBUG "%s: %02x:", I2C_NAME(client),

				v);

			for (j = 0; j < 16; j++) {

				dprintk(1, KERN_INFO " %02x",

					decoder->reg[v + j]);

			}

			dprintk(1, KERN_INFO "\n");

			for (j = 0; j < 16 && v + j < SAA7110_NR_REG; j++)

				dprintk(1, " %02x", decoder->reg[v + j]);

			dprintk(1, "\n");

		}

		break;