Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61a22e72 authored by David Dai's avatar David Dai
Browse files

msm: msm_bus: Disallow single node paths 



Reject clients that attempt to register paths that have the
same source and destination. Add additional null ptr checks for
bus nodes that have no fabrice devices attached to them.

Change-Id: I13320371b2b19f6047853ffc7ffe529c0bfbd620
Signed-off-by: default avatarDavid Dai <daidavid1@codeaurora.org>
parent e2399b46

drivers/platform/msm/msm_bus/msm_bus_arb_adhoc.c

+3 −2
Original line number Diff line number Diff line
@@ -552,7 +552,8 @@ static uint64_t aggregate_bus_req(struct msm_bus_node_device_type *bus_dev, 
	uint64_t max_ab = 0;

	uint64_t sum_ab = 0;



	if (!bus_dev || !to_msm_bus_node(bus_dev->node_info->bus_device)) {

	if (!bus_dev || !bus_dev->node_info->bus_device ||

			!to_msm_bus_node(bus_dev->node_info->bus_device)) {

		MSM_BUS_ERR("Bus node pointer is Invalid");

		goto exit_agg_bus_req;

	}
@@ -1016,7 +1017,7 @@ static uint32_t register_client_adhoc(struct msm_bus_scale_pdata *pdata) 
		src = pdata->usecase->vectors[i].src;

		dest = pdata->usecase->vectors[i].dst;



		if ((src < 0) || (dest < 0)) {

		if ((src < 0) || (dest < 0) || (src == dest)) {

			MSM_BUS_ERR("%s:Invalid src/dst.src %d dest %d",

				__func__, src, dest);

			goto exit_invalid_data;