Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6173d1d7 authored by Kangjie Lu's avatar Kangjie Lu Committed by Gerrit - the friendly Code Review server
Browse files

net: fix infoleak in rtnetlink 



The stack object “map” has a total size of 32 bytes. Its last 4
bytes are padding generated by compiler. These padding bytes are
not initialized and sent out via “nla_put”.

Conflicts:
	net/core/rtnetlink.c

b/28620102
Signed-off-by: default avatarKangjie Lu <kjlu@gatech.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarDennis Cagle <d-cagle@codeaurora.org>
Git-commit: 5f8e44741f9f216e33736ea4ec65ca9ac03036e6
Git-repo: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git
(cherry picked from commit 5f8e44741f9f216e33736ea4ec65ca9ac03036e6)
Change-Id: I41f4745f24720c7af5ab08dc4274224d7fe4dcfe
parent 995bb603

net/core/rtnetlink.c

+8 −0
Original line number Diff line number Diff line
@@ -1027,6 +1027,14 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev, 
			.dma         = dev->dma,

			.port        = dev->if_port,

		};

		memset(&map, 0, sizeof(map));

		map.mem_start   = dev->mem_start;

		map.mem_end     = dev->mem_end;

		map.base_addr   = dev->base_addr;

		map.irq         = dev->irq;

		map.dma         = dev->dma;

		map.port        = dev->if_port;



		if (nla_put(skb, IFLA_MAP, sizeof(map), &map))

			goto nla_put_failure;

	}