Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61241d97 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

drivers/staging: delete double assignment 

Delete successive assignments to the same location.  In three of the cases,
the two assignments are identical.  In the case of the file
rt2860/common/cmm_aes.c, the assigned variable i is never used, so both
assignments are dropped.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression i;
@@

*i = ...;
 i = ...;
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 22b4dc59

drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c

+0 −1
Original line number Diff line number Diff line
@@ -286,7 +286,6 @@ int ft1000_CreateDevice(struct ft1000_device *dev) 
    pid = kernel_thread (exec_mknod, (void *)info, 0);



    // initialize application information

    info->appcnt = 0;



//    if (ft1000_flarion_cnt == 0) {

//

drivers/staging/hv/hv_utils.c

+0 −3
Original line number Diff line number Diff line
@@ -214,9 +214,6 @@ static void heartbeat_onchannelcallback(void *context) 
		icmsghdrp = (struct icmsg_hdr *)&buf[

				sizeof(struct vmbuspipe_hdr)];



		icmsghdrp = (struct icmsg_hdr *)&buf[

				sizeof(struct vmbuspipe_hdr)];



		if (icmsghdrp->icmsgtype == ICMSGTYPE_NEGOTIATE) {

			prep_negotiate_resp(icmsghdrp, NULL, buf);

		} else {

drivers/staging/rt2860/common/cmm_aes.c

+0 −2
Original line number Diff line number Diff line
@@ -330,8 +330,6 @@ void construct_mic_iv(unsigned char *mic_iv, 
	for (i = 8; i < 14; i++)

		mic_iv[i] = pn_vector[13 - i];	/* mic_iv[8:13] = PN[5:0] */

#endif

	i = (payload_length / 256);

	i = (payload_length % 256);

	mic_iv[14] = (unsigned char)(payload_length / 256);

	mic_iv[15] = (unsigned char)(payload_length % 256);

drivers/staging/westbridge/astoria/api/src/cyasusb.c

+0 −1
Original line number Diff line number Diff line
@@ -1417,7 +1417,6 @@ cy_as_usb_set_enum_config(cy_as_device_handle handle, 
	 */

	bus_mask   = 0;

	media_mask = 0;

	media_mask = 0;

	for (bus = 0; bus < CY_AS_MAX_BUSES; bus++) {

		for (device = 0; device < CY_AS_MAX_STORAGE_DEVICES; device++) {

			if (config_p->devices_to_enumerate[bus][device] ==