Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6115e855 authored by Senthil Balasubramanian's avatar Senthil Balasubramanian Committed by John W. Linville
Browse files

ath9k: Fix IRQ nobody cared issue with ath9k 



IRQs should be disabled before calling free_irq. Also flush pending
IRQs. Pasted the kernel log message for reference.

kernel: irq 17: nobody cared (try booting with the "irqpoll" option)
kernel:  [<c0252d2c>] __report_bad_irq+0x2e/0x6f
kernel:  [<c0252f22>] note_interrupt+0x1b5/0x207
kernel:  [<c025258b>] ? handle_IRQ_event+0x21/0x48
kernel:  [<c02534cb>] handle_fasteoi_irq+0x8e/0xad
kernel:  [<c0205650>] do_IRQ+0x6c/0x84
kernel:  [<c020425f>] common_interrupt+0x23/0x28
kernel:  [<c034f6f6>] ? acpi_idle_enter_simple+0x198/0x205
kernel:  [<c044686c>] ? menu_select+0x5c/0x78
kernel:  [<c0445a95>] cpuidle_idle_call+0x59/0x89
kernel:  [<c02029d7>] cpu_idle+0xae/0xcf
kernel:  [<c0543102>] rest_init+0x4e/0x50
kernel:  =======================
kernel: handlers:
kernel: [<f88fdd26>] (ath_isr+0x0/0x13a [ath9k])
kernel: Disabling IRQ #17

Signed-off-by: default avatarSenthil Balasubramanian <senthilkumar@atheros.com>
Tested-by: default avatarSteven Noonan <steven@uplinklabs.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 5d89945e

drivers/net/wireless/ath9k/core.c

+2 −2
Original line number Diff line number Diff line
@@ -294,8 +294,6 @@ static int ath_stop(struct ath_softc *sc) 
	 * hardware is gone (invalid).

	 */



	if (!sc->sc_invalid)

		ath9k_hw_set_interrupts(ah, 0);

	ath_draintxq(sc, false);

	if (!sc->sc_invalid) {

		ath_stoprecv(sc);
@@ -1336,6 +1334,8 @@ void ath_deinit(struct ath_softc *sc) 


	DPRINTF(sc, ATH_DBG_CONFIG, "%s\n", __func__);



	tasklet_kill(&sc->intr_tq);

	tasklet_kill(&sc->bcon_tasklet);

	ath_stop(sc);

	if (!sc->sc_invalid)

		ath9k_hw_setpower(sc->sc_ah, ATH9K_PM_AWAKE);

drivers/net/wireless/ath9k/main.c

+8 −1
Original line number Diff line number Diff line
@@ -1411,10 +1411,17 @@ static void ath_pci_remove(struct pci_dev *pdev) 
{

	struct ieee80211_hw *hw = pci_get_drvdata(pdev);

	struct ath_softc *sc = hw->priv;

	enum ath9k_int status;



	if (pdev->irq)

	if (pdev->irq) {

		ath9k_hw_set_interrupts(sc->sc_ah, 0);

		/* clear the ISR */

		ath9k_hw_getisr(sc->sc_ah, &status);

		sc->sc_invalid = 1;

		free_irq(pdev->irq, sc);

	}

	ath_detach(sc);



	pci_iounmap(pdev, sc->mem);

	pci_release_region(pdev, 0);

	pci_disable_device(pdev);