Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 600991b0 authored by Uwe Zeisberger's avatar Uwe Zeisberger Committed by Jeff Garzik
Browse files

[PATCH] Fix phy id for LXT971A/LXT972A 



From: Uwe Zeisberger <Uwe_Zeisberger@digi.com>

The phy ids used are taken from an driver that used a right shift of 4 to chop
off the revision number.  This driver does not shift, so the id and mask
values are wrong and must be left shifted by 4 to actually detect the chips.

Signed-off-by: default avatarUwe Zeisberger <Uwe_Zeisberger@digi.com>
Acked-by: default avatarAndy Fleming <afleming@freescale.com>

[akpm: this is a previously-nacked patch, but the problem is real]
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 5d22a312

drivers/net/phy/lxt.c

+4 −4
Original line number Diff line number Diff line
@@ -123,9 +123,9 @@ static int lxt971_config_intr(struct phy_device *phydev) 
}



static struct phy_driver lxt970_driver = {

	.phy_id		= 0x07810000,

	.phy_id		= 0x78100000,

	.name		= "LXT970",

	.phy_id_mask	= 0x0fffffff,

	.phy_id_mask	= 0xfffffff0,

	.features	= PHY_BASIC_FEATURES,

	.flags		= PHY_HAS_INTERRUPT,

	.config_init	= lxt970_config_init,
@@ -137,9 +137,9 @@ static struct phy_driver lxt970_driver = { 
};



static struct phy_driver lxt971_driver = {

	.phy_id		= 0x0001378e,

	.phy_id		= 0x001378e0,

	.name		= "LXT971",

	.phy_id_mask	= 0x0fffffff,

	.phy_id_mask	= 0xfffffff0,

	.features	= PHY_BASIC_FEATURES,

	.flags		= PHY_HAS_INTERRUPT,

	.config_aneg	= genphy_config_aneg,