Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fe18b3d authored by Jason Andryuk's avatar Jason Andryuk Committed by Greg Kroah-Hartman
Browse files

HID: i2c-hid: Fix "incomplete report" noise 



commit ef6eaf27274c0351f7059163918f3795da13199c upstream.

Commit ac75a041048b ("HID: i2c-hid: fix size check and type usage") started
writing messages when the ret_size is <= 2 from i2c_master_recv.  However, my
device i2c-DLL07D1 returns 2 for a short period of time (~0.5s) after I stop
moving the pointing stick or touchpad.  It varies, but you get ~50 messages
each time which spams the log hard.

[  95.925055] i2c_hid i2c-DLL07D1:01: i2c_hid_get_input: incomplete report (83/2)

This has also been observed with a i2c-ALP0017.

[ 1781.266353] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2)

Only print the message when ret_size is totally invalid and less than 2 to cut
down on the log spam.

Fixes: ac75a041048b ("HID: i2c-hid: fix size check and type usage")
Reported-by: default avatarJohn Smith <john-s-84@gmx.net>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJason Andryuk <jandryuk@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 55b0c5e2

drivers/hid/i2c-hid/i2c-hid.c

+1 −1
Original line number Diff line number Diff line
@@ -399,7 +399,7 @@ static void i2c_hid_get_input(struct i2c_hid *ihid) 
		return;

	}



	if ((ret_size > size) || (ret_size <= 2)) {

	if ((ret_size > size) || (ret_size < 2)) {

		dev_err(&ihid->client->dev, "%s: incomplete report (%d/%d)\n",

			__func__, size, ret_size);

		return;