Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f634d06 authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Theodore Ts'o
Browse files

ext4: Fix quota accounting error with fallocate 



When we fallocate a region of the file which we had recently written,
and which is still in the page cache marked as delayed allocated blocks
we need to make sure we don't do the quota update on writepage path.
This is because the needed quota updated would have already be done
by fallocate.

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
parent 1db91382

fs/ext4/ext4.h

+2 −0
Original line number Original line Diff line number Diff line
@@ -1443,6 +1443,8 @@ extern int ext4_block_truncate_page(handle_t *handle, 
extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf);

extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf);

extern qsize_t *ext4_get_reserved_space(struct inode *inode);

extern qsize_t *ext4_get_reserved_space(struct inode *inode);

extern int flush_aio_dio_completed_IO(struct inode *inode);

extern int flush_aio_dio_completed_IO(struct inode *inode);

extern void ext4_da_update_reserve_space(struct inode *inode,

					int used, int quota_claim);

/* ioctl.c */

/* ioctl.c */

extern long ext4_ioctl(struct file *, unsigned int, unsigned long);

extern long ext4_ioctl(struct file *, unsigned int, unsigned long);

extern long ext4_compat_ioctl(struct file *, unsigned int, unsigned long);

extern long ext4_compat_ioctl(struct file *, unsigned int, unsigned long);

fs/ext4/extents.c

+21 −0
Original line number Original line Diff line number Diff line
@@ -3132,7 +3132,19 @@ out: 
		unmap_underlying_metadata_blocks(inode->i_sb->s_bdev,

		unmap_underlying_metadata_blocks(inode->i_sb->s_bdev,

					newblock + max_blocks,

					newblock + max_blocks,

					allocated - max_blocks);

					allocated - max_blocks);

		allocated = max_blocks;

	}

	}



	/*

	 * If we have done fallocate with the offset that is already

	 * delayed allocated, we would have block reservation

	 * and quota reservation done in the delayed write path.

	 * But fallocate would have already updated quota and block

	 * count for this offset. So cancel these reservation

	 */

	if (flags & EXT4_GET_BLOCKS_UPDATE_RESERVE_SPACE)

		ext4_da_update_reserve_space(inode, allocated, 0);



map_out:

map_out:

	set_buffer_mapped(bh_result);

	set_buffer_mapped(bh_result);

out1:

out1:
@@ -3368,8 +3380,17 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, 
	/* previous routine could use block we allocated */

	/* previous routine could use block we allocated */

	newblock = ext_pblock(&newex);

	newblock = ext_pblock(&newex);

	allocated = ext4_ext_get_actual_len(&newex);

	allocated = ext4_ext_get_actual_len(&newex);

	if (allocated > max_blocks)

		allocated = max_blocks;

	set_buffer_new(bh_result);

	set_buffer_new(bh_result);





	/*

	 * Update reserved blocks/metadata blocks after successful

	 * block allocation which had been deferred till now.

	 */

	if (flags & EXT4_GET_BLOCKS_UPDATE_RESERVE_SPACE)

		ext4_da_update_reserve_space(inode, allocated, 1);



	/*

	/*

	 * Cache the extent and update transaction to commit on fdatasync only

	 * Cache the extent and update transaction to commit on fdatasync only

	 * when it is _not_ an uninitialized extent.

	 * when it is _not_ an uninitialized extent.

fs/ext4/inode.c

+31 −13
Original line number Original line Diff line number Diff line
@@ -1053,11 +1053,12 @@ static int ext4_calc_metadata_amount(struct inode *inode, sector_t lblock) 
 * Called with i_data_sem down, which is important since we can call

 * Called with i_data_sem down, which is important since we can call

 * ext4_discard_preallocations() from here.

 * ext4_discard_preallocations() from here.

 */

 */

static void ext4_da_update_reserve_space(struct inode *inode, int used)

void ext4_da_update_reserve_space(struct inode *inode,

					int used, int quota_claim)

{

{

	struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);

	struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);

	struct ext4_inode_info *ei = EXT4_I(inode);

	struct ext4_inode_info *ei = EXT4_I(inode);

	int mdb_free = 0;

	int mdb_free = 0, allocated_meta_blocks = 0;





	spin_lock(&ei->i_block_reservation_lock);

	spin_lock(&ei->i_block_reservation_lock);

	if (unlikely(used > ei->i_reserved_data_blocks)) {

	if (unlikely(used > ei->i_reserved_data_blocks)) {
@@ -1073,6 +1074,7 @@ static void ext4_da_update_reserve_space(struct inode *inode, int used) 
	ei->i_reserved_data_blocks -= used;

	ei->i_reserved_data_blocks -= used;

	used += ei->i_allocated_meta_blocks;

	used += ei->i_allocated_meta_blocks;

	ei->i_reserved_meta_blocks -= ei->i_allocated_meta_blocks;

	ei->i_reserved_meta_blocks -= ei->i_allocated_meta_blocks;

	allocated_meta_blocks = ei->i_allocated_meta_blocks;

	ei->i_allocated_meta_blocks = 0;

	ei->i_allocated_meta_blocks = 0;

	percpu_counter_sub(&sbi->s_dirtyblocks_counter, used);

	percpu_counter_sub(&sbi->s_dirtyblocks_counter, used);
@@ -1090,9 +1092,23 @@ static void ext4_da_update_reserve_space(struct inode *inode, int used) 
	spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);

	spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);





	/* Update quota subsystem */

	/* Update quota subsystem */

	if (quota_claim) {

		vfs_dq_claim_block(inode, used);

		vfs_dq_claim_block(inode, used);

		if (mdb_free)

		if (mdb_free)

			vfs_dq_release_reservation_block(inode, mdb_free);

			vfs_dq_release_reservation_block(inode, mdb_free);

	} else {

		/*

		 * We did fallocate with an offset that is already delayed

		 * allocated. So on delayed allocated writeback we should

		 * not update the quota for allocated blocks. But then

		 * converting an fallocate region to initialized region would

		 * have caused a metadata allocation. So claim quota for

		 * that

		 */

		if (allocated_meta_blocks)

			vfs_dq_claim_block(inode, allocated_meta_blocks);

		vfs_dq_release_reservation_block(inode, mdb_free + used);

	}





	/*

	/*

	 * If we have done all the pending block allocations and if

	 * If we have done all the pending block allocations and if
@@ -1292,17 +1308,19 @@ int ext4_get_blocks(handle_t *handle, struct inode *inode, sector_t block, 
			 */

			 */

			EXT4_I(inode)->i_state &= ~EXT4_STATE_EXT_MIGRATE;

			EXT4_I(inode)->i_state &= ~EXT4_STATE_EXT_MIGRATE;

		}

		}

	}



	if (flags & EXT4_GET_BLOCKS_DELALLOC_RESERVE)

		EXT4_I(inode)->i_delalloc_reserved_flag = 0;





		/*

		/*

		 * Update reserved blocks/metadata blocks after successful

		 * Update reserved blocks/metadata blocks after successful

	 * block allocation which had been deferred till now.

		 * block allocation which had been deferred till now. We don't

		 * support fallocate for non extent files. So we can update

		 * reserve space here.

		 */

		 */

	if ((retval > 0) && (flags & EXT4_GET_BLOCKS_UPDATE_RESERVE_SPACE))

		if ((retval > 0) &&

		ext4_da_update_reserve_space(inode, retval);

			(flags & EXT4_GET_BLOCKS_UPDATE_RESERVE_SPACE))

			ext4_da_update_reserve_space(inode, retval, 1);

	}

	if (flags & EXT4_GET_BLOCKS_DELALLOC_RESERVE)

		EXT4_I(inode)->i_delalloc_reserved_flag = 0;





	up_write((&EXT4_I(inode)->i_data_sem));

	up_write((&EXT4_I(inode)->i_data_sem));

	if (retval > 0 && buffer_mapped(bh)) {

	if (retval > 0 && buffer_mapped(bh)) {