Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f63306d authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] cx231xx: use bitwise negate instead of logical 



Bitwise negate was intended here.  INPUT_SEL_MASK is 0x30.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a3fa904e

drivers/media/video/cx231xx/cx231xx-avcore.c

+3 −3
Original line number Diff line number Diff line
@@ -274,7 +274,7 @@ int cx231xx_afe_set_input_mux(struct cx231xx *dev, u32 input_mux) 


	if (ch1_setting != 0) {

		status = afe_read_byte(dev, ADC_INPUT_CH1, &value);

		value &= (!INPUT_SEL_MASK);

		value &= ~INPUT_SEL_MASK;

		value |= (ch1_setting - 1) << 4;

		value &= 0xff;

		status = afe_write_byte(dev, ADC_INPUT_CH1, value);
@@ -282,7 +282,7 @@ int cx231xx_afe_set_input_mux(struct cx231xx *dev, u32 input_mux) 


	if (ch2_setting != 0) {

		status = afe_read_byte(dev, ADC_INPUT_CH2, &value);

		value &= (!INPUT_SEL_MASK);

		value &= ~INPUT_SEL_MASK;

		value |= (ch2_setting - 1) << 4;

		value &= 0xff;

		status = afe_write_byte(dev, ADC_INPUT_CH2, value);
@@ -292,7 +292,7 @@ int cx231xx_afe_set_input_mux(struct cx231xx *dev, u32 input_mux) 
	   7 less than the input number */

	if (ch3_setting != 0) {

		status = afe_read_byte(dev, ADC_INPUT_CH3, &value);

		value &= (!INPUT_SEL_MASK);

		value &= ~INPUT_SEL_MASK;

		value |= (ch3_setting - 1) << 4;

		value &= 0xff;

		status = afe_write_byte(dev, ADC_INPUT_CH3, value);