Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5dbabace authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: garmin_gps: remove bogus disconnect test in bulk callback 



Remove bogus disconnect test for serial device being NULL in read bulk
callback. This can never happen as the port read urb is killed (and
poisoned) at close, which in turn is guaranteed to be called before the
last tty reference is dropped (and port->serial is cleared).

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 91972724

drivers/usb/serial/garmin_gps.c

+0 −6
Original line number Diff line number Diff line
@@ -1181,17 +1181,11 @@ static void garmin_read_bulk_callback(struct urb *urb) 
{

	unsigned long flags;

	struct usb_serial_port *port = urb->context;

	struct usb_serial *serial =  port->serial;

	struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);

	unsigned char *data = urb->transfer_buffer;

	int status = urb->status;

	int retval;



	if (!serial) {

		dev_dbg(&urb->dev->dev, "%s - bad serial pointer, exiting\n", __func__);

		return;

	}



	if (status) {

		dev_dbg(&urb->dev->dev, "%s - nonzero read bulk status received: %d\n",

			__func__, status);