Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d540fb7 authored by Christoph Lameter's avatar Christoph Lameter Committed by Linus Torvalds
Browse files

slub: do not fail if we cannot register a slab with sysfs 



Do not BUG() if we cannot register a slab with sysfs.  Just print an error.
 The only consequence of not registering is that the slab cache is not
visible via /sys/slab.  A BUG() may not be visible that early during boot
and we have had multiple issues here already.

Signed-off-by: default avatarChristoph Lameter <clameter@sgi.com>
Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 4ccdb4c8

mm/slub.c

+6 −2
Original line number Diff line number Diff line
@@ -3813,7 +3813,9 @@ static int __init slab_sysfs_init(void) 


	list_for_each_entry(s, &slab_caches, list) {

		err = sysfs_slab_add(s);

		BUG_ON(err);

		if (err)

			printk(KERN_ERR "SLUB: Unable to add boot slab %s"

						" to sysfs\n", s->name);

	}



	while (alias_list) {
@@ -3821,7 +3823,9 @@ static int __init slab_sysfs_init(void) 


		alias_list = alias_list->next;

		err = sysfs_slab_alias(al->s, al->name);

		BUG_ON(err);

		if (err)

			printk(KERN_ERR "SLUB: Unable to add boot slab alias"

					" %s to sysfs\n", s->name);

		kfree(al);

	}