Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d44aa4c authored by Hannes Eder's avatar Hannes Eder Committed by Takashi Iwai
Browse files

sound/oss: fix sparse warnings: different signedness 



Impact: Change signature of 'set_volume_stereo' and 'set_volume_mono'.

Fix this sparse warnings:
  sound/oss/pss.c:545:42: warning: incorrect type in argument 2 (different signedness)
  sound/oss/pss.c:546:42: warning: incorrect type in argument 3 (different signedness)
  sound/oss/pss.c:554:59: warning: incorrect type in argument 2 (different signedness)
  sound/oss/pss.c:560:59: warning: incorrect type in argument 2 (different signedness)
  sound/oss/pss.c:566:59: warning: incorrect type in argument 2 (different signedness)

Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent eca985d2

sound/oss/pss.c

+6 −6
Original line number Diff line number Diff line
@@ -457,10 +457,9 @@ static void pss_mixer_reset(pss_confdata *devc) 
	}

}



static int set_volume_mono(unsigned __user *p, int *aleft)

static int set_volume_mono(unsigned __user *p, unsigned int *aleft)

{

	int left;

	unsigned volume;

	unsigned int left, volume;

	if (get_user(volume, p))

		return -EFAULT;
@@ -471,10 +470,11 @@ static int set_volume_mono(unsigned __user *p, int *aleft) 
	return 0;

}



static int set_volume_stereo(unsigned __user *p, int *aleft, int *aright)

static int set_volume_stereo(unsigned __user *p,

			     unsigned int *aleft,

			     unsigned int *aright)

{

	int left, right;

	unsigned volume;

	unsigned int left, right, volume;

	if (get_user(volume, p))

		return -EFAULT;