Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d3a551c authored by Will Deacon's avatar Will Deacon Committed by Linus Torvalds
Browse files

mm: hugetlb: add arch hook for clearing page flags before entering pool 



The core page allocator ensures that page flags are zeroed when freeing
pages via free_pages_check.  A number of architectures (ARM, PPC, MIPS)
rely on this property to treat new pages as dirty with respect to the data
cache and perform the appropriate flushing before mapping the pages into
userspace.

This can lead to cache synchronisation problems when using hugepages,
since the allocator keeps its own pool of pages above the usual page
allocator and does not reset the page flags when freeing a page into the
pool.

This patch adds a new architecture hook, arch_clear_hugepage_flags, so
that architectures which rely on the page flags being in a particular
state for fresh allocations can adjust the flags accordingly when a page
is freed into the pool.

Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
Cc: Michal Hocko <mhocko@suse.cz>
Reviewed-by: default avatarMichal Hocko <mhocko@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 01dc52eb

arch/ia64/include/asm/hugetlb.h

+4 −0
Original line number Original line Diff line number Diff line
@@ -77,4 +77,8 @@ static inline void arch_release_hugepage(struct page *page) 
{

{

}

}





static inline void arch_clear_hugepage_flags(struct page *page)

{

}



#endif /* _ASM_IA64_HUGETLB_H */
 
#endif /* _ASM_IA64_HUGETLB_H */

arch/mips/include/asm/hugetlb.h

+4 −0
Original line number Original line Diff line number Diff line
@@ -112,4 +112,8 @@ static inline void arch_release_hugepage(struct page *page) 
{

{

}

}





static inline void arch_clear_hugepage_flags(struct page *page)

{

}



#endif /* __ASM_HUGETLB_H */
 
#endif /* __ASM_HUGETLB_H */

arch/powerpc/include/asm/hugetlb.h

+4 −0
Original line number Original line Diff line number Diff line
@@ -151,6 +151,10 @@ static inline void arch_release_hugepage(struct page *page) 
{

{

}

}





static inline void arch_clear_hugepage_flags(struct page *page)

{

}



#else /* ! CONFIG_HUGETLB_PAGE */

#else /* ! CONFIG_HUGETLB_PAGE */

static inline void flush_hugetlb_page(struct vm_area_struct *vma,

static inline void flush_hugetlb_page(struct vm_area_struct *vma,

				      unsigned long vmaddr)

				      unsigned long vmaddr)

arch/s390/include/asm/hugetlb.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -33,6 +33,7 @@ static inline int prepare_hugepage_range(struct file *file, 
}

}





#define hugetlb_prefault_arch_hook(mm)		do { } while (0)

#define hugetlb_prefault_arch_hook(mm)		do { } while (0)

#define arch_clear_hugepage_flags(page)		do { } while (0)





int arch_prepare_hugepage(struct page *page);

int arch_prepare_hugepage(struct page *page);

void arch_release_hugepage(struct page *page);

void arch_release_hugepage(struct page *page);

arch/sh/include/asm/hugetlb.h

+6 −0
Original line number Original line Diff line number Diff line 
#ifndef _ASM_SH_HUGETLB_H

#ifndef _ASM_SH_HUGETLB_H

#define _ASM_SH_HUGETLB_H

#define _ASM_SH_HUGETLB_H





#include <asm/cacheflush.h>

#include <asm/page.h>

#include <asm/page.h>
@@ -89,4 +90,9 @@ static inline void arch_release_hugepage(struct page *page) 
{

{

}

}





static inline void arch_clear_hugepage_flags(struct page *page)

{

	clear_bit(PG_dcache_clean, &page->flags);

}



#endif /* _ASM_SH_HUGETLB_H */
 
#endif /* _ASM_SH_HUGETLB_H */