Commit 5d06dc06 authored Apr 30, 2018 by Eric Biggers Committed by Jaegeuk Kim Jun 28, 2018

fscrypt: don't clear flags on crypto transform



fscrypt is clearing the flags on the crypto_skcipher it allocates for
each inode.  But, this is unnecessary and may cause problems in the
future because it will even clear flags that are meant to be internal to
the crypto API, e.g. CRYPTO_TFM_NEED_KEY.

Remove the unnecessary flag clearing.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent d04f0f3c

fs/crypto/keyinfo.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -337,7 +337,6 @@ int fscrypt_get_encryption_info(struct inode *inode)
		goto out;
		}
		crypt_info->ci_ctfm = ctfm;
		crypto_ablkcipher_clear_flags(ctfm, ~0);
		crypto_ablkcipher_set_flags(ctfm, CRYPTO_TFM_REQ_WEAK_KEY);
		/*
		* if the provided key is longer than keysize, we use the first