Commit 5c2edefe authored Oct 23, 2012 by Ezequiel Garcia Committed by Mauro Carvalho Chehab Dec 27, 2012

[media] pwc: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 5869bb39

drivers/media/usb/pwc/pwc-if.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1008,7 +1008,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
		}

		/* Init video_device structure */
		memcpy(&pdev->vdev, &pwc_template, sizeof(pwc_template));
		pdev->vdev = pwc_template;
		strcpy(pdev->vdev.name, name);
		pdev->vdev.queue = &pdev->vb_queue;
		pdev->vdev.queue->lock = &pdev->vb_queue_lock;