Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b615287 authored by Eric Sandeen's avatar Eric Sandeen Committed by Theodore Ts'o
Browse files

ext4: fix setup_new_group_blocks locking 



setup_new_group_blocks() manipulates the group descriptor block bh
under the block_bitmap bh's lock.  It shouldn't matter since nobody
but resize should be touching these blocks, but it's worth fixing up.

Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
Signed-off-by: default avatarMingming Cao <cmm@us.ibm.com>
parent ac39849d

fs/ext4/resize.c

+3 −3
Original line number Diff line number Diff line
@@ -199,10 +199,10 @@ static int setup_new_group_blocks(struct super_block *sb, 
			brelse(gdb);

			goto exit_bh;

		}

		lock_buffer(bh);

		memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, bh->b_size);

		lock_buffer(gdb);

		memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size);

		set_buffer_uptodate(gdb);

		unlock_buffer(bh);

		unlock_buffer(gdb);

		ext4_journal_dirty_metadata(handle, gdb);

		ext4_set_bit(bit, bh->b_data);

		brelse(gdb);