Commit 5b3ab1db authored Jul 23, 2008 by David S. Miller

netdev: Remove warning from __netif_schedule().

It isn't helping anything and we aren't going to be able to change all
the drivers that do queue wakeups in strange situations.

Just letting a noop_qdisc get scheduled will work because when
qdisc_run() executes via net_tx_work() it will simply find no packets
pending when it makes the ->dequeue() call in qdisc_restart.

Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8a6d2ea0

net/core/dev.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -1341,9 +1341,6 @@ static void dev_queue_xmit_nit(struct sk_buff skb, struct net_device dev)

	void __netif_schedule(struct Qdisc *q)		void __netif_schedule(struct Qdisc *q)
	{		{
	if (WARN_ON_ONCE(q == &noop_qdisc))
	return;

	if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state)) {		if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state)) {
	struct softnet_data *sd;		struct softnet_data *sd;
	unsigned long flags;		unsigned long flags;