Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5aae810c authored by Richard Weinberger's avatar Richard Weinberger Committed by Greg Kroah-Hartman
Browse files

ubi: Reject MLC NAND 



commit b5094b7f135be34630e3ea8a98fa215715d0f29d upstream.

While UBI and UBIFS seem to work at first sight with MLC NAND, you will
most likely lose all your data upon a power-cut or due to read/write
disturb.
In order to protect users from bad surprises, refuse to attach to MLC
NAND.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Acked-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
Acked-by: default avatarArtem Bityutskiy <dedekind1@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1c9fcf71

drivers/mtd/ubi/build.c

+11 −0
Original line number Diff line number Diff line
@@ -905,6 +905,17 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num, 
		return -EINVAL;

	}



	/*

	 * Both UBI and UBIFS have been designed for SLC NAND and NOR flashes.

	 * MLC NAND is different and needs special care, otherwise UBI or UBIFS

	 * will die soon and you will lose all your data.

	 */

	if (mtd->type == MTD_MLCNANDFLASH) {

		pr_err("ubi: refuse attaching mtd%d - MLC NAND is not supported\n",

			mtd->index);

		return -EINVAL;

	}



	if (ubi_num == UBI_DEV_NUM_AUTO) {

		/* Search for an empty slot in the @ubi_devices array */

		for (ubi_num = 0; ubi_num < UBI_MAX_DEVICES; ubi_num++)