Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a3ef810 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] fmdrv: Don't check if unsigned are below zero 



drivers/media/radio/wl128x/fmdrv_common.c:745:3: warning: comparison is always false due to limited range of data type [-Wtype-limits]
drivers/media/radio/wl128x/fmdrv_rx.c:308:2: warning: comparison is always false due to limited range of data type [-Wtype-limits]

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 84cc2377

drivers/media/radio/wl128x/fmdrv_common.c

+1 −1
Original line number Diff line number Diff line
@@ -742,7 +742,7 @@ static void fm_irq_handle_rdsdata_getcmd_resp(struct fmdev *fmdev) 
		if ((meta_data & FM_RDS_STATUS_ERR_MASK) != 0)

			break;



		if (blk_idx < FM_RDS_BLK_IDX_A || blk_idx > FM_RDS_BLK_IDX_D) {

		if (blk_idx > FM_RDS_BLK_IDX_D) {

			fmdbg("Block sequence mismatch\n");

			rds->last_blk_idx = -1;

			break;

drivers/media/radio/wl128x/fmdrv_rx.c

+1 −1
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ int fm_rx_set_volume(struct fmdev *fmdev, u16 vol_to_set) 
	if (fmdev->curr_fmmode != FM_MODE_RX)

		return -EPERM;



	if (vol_to_set < FM_RX_VOLUME_MIN || vol_to_set > FM_RX_VOLUME_MAX) {

	if (vol_to_set > FM_RX_VOLUME_MAX) {

		fmerr("Volume is not within(%d-%d) range\n",

			   FM_RX_VOLUME_MIN, FM_RX_VOLUME_MAX);

		return -EINVAL;