Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a313c59 authored by Jean Delvare's avatar Jean Delvare Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (3568j): adv7175: Drop unused encoder dump command 



Drop support for the ENCODER_DUMP command in the adv7175 driver.  ENCODER_DUMP
was never actually defined as far as I can see, so the code was ifdef'd out,
and I suspect it was never used, not even once, as it includes an obvious
array overrun.

The register values of this specific chip can be dumped in a generic way using
the i2c-dev driver and the "i2cdump" user-space tool if it is ever really
needed.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 2467a670

drivers/media/video/adv7175.c

+0 −26
Original line number Diff line number Diff line
@@ -165,24 +165,6 @@ set_subcarrier_freq (struct i2c_client *client, 
	adv7175_write(client, 0x05, 0x25);

}



#ifdef ENCODER_DUMP

static void

dump (struct i2c_client *client)

{

	struct adv7175 *encoder = i2c_get_clientdata(client);

	int i, j;



	printk(KERN_INFO "%s: registry dump\n", I2C_NAME(client));

	for (i = 0; i < 182 / 8; i++) {

		printk("%s: 0x%02x -", I2C_NAME(client), i * 8);

		for (j = 0; j < 8; j++) {

			printk(" 0x%02x", encoder->reg[i * 8 + j]);

		}

		printk("\n");

	}

}

#endif



/* ----------------------------------------------------------------------- */

// Output filter:  S-Video  Composite
@@ -401,14 +383,6 @@ adv7175_command (struct i2c_client *client, 
	}

		break;



#ifdef ENCODER_DUMP

	case ENCODER_DUMP:

	{

		dump(client);

	}

		break;

#endif



	default:

		return -EINVAL;

	}