Commit 5a2f613a authored Oct 07, 2017 by Jan Beulich Committed by Greg Kroah-Hartman Nov 08, 2017

xen/manage: correct return value check on xenbus_scanf()




[ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]

A negative return value indicates an error; in fact the function at
present won't ever return zero.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e79412f6

drivers/xen/manage.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -272,7 +272,7 @@ static void sysrq_handler(struct xenbus_watch watch, const char *vec,
		err = xenbus_transaction_start(&xbt);
		if (err)
		return;
		if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) {
		if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) {
		pr_err("Unable to read sysrq code in control/sysrq\n");
		xenbus_transaction_end(xbt, 1);
		return;