Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a02ab7c authored by Mi Jinlong's avatar Mi Jinlong Committed by J. Bruce Fields
Browse files

nfsd: wrong index used in inner loop 



We must not use dummy for index.
After the first index, READ32(dummy) will change dummy!!!!

Signed-off-by: default avatarMi Jinlong <mijinlong@cn.fujitsu.com>
[bfields@redhat.com: Trond points out READ_BUF alone is sufficient.]
Cc: stable@kernel.org
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent cf507b6f

fs/nfsd/nfs4xdr.c

+1 −4
Original line number Diff line number Diff line
@@ -1142,7 +1142,7 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, 


	u32 dummy;

	char *machine_name;

	int i, j;

	int i;

	int nr_secflavs;



	READ_BUF(16);
@@ -1215,8 +1215,6 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, 
			READ_BUF(4);

			READ32(dummy);

			READ_BUF(dummy * 4);

			for (j = 0; j < dummy; ++j)

				READ32(dummy);

			break;

		case RPC_AUTH_GSS:

			dprintk("RPC_AUTH_GSS callback secflavor "
@@ -1232,7 +1230,6 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp, 
			READ_BUF(4);

			READ32(dummy);

			READ_BUF(dummy);

			p += XDR_QUADLEN(dummy);

			break;

		default:

			dprintk("Illegal callback secflavor\n");