Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59ede316 authored by Bjørn Mork's avatar Bjørn Mork Committed by David S. Miller
Browse files

net: cdc_ncm: return proper error if setup fails 



Most setup errors are ignored to ensure maximum firmware
compatibilty.  But GET_NTB_PARAMETERS and the functional
descriptors are required.  Use proper error codes and
log level if these fail.

Cc: Alexey Orishko <alexey.orishko@gmail.com>
Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 47175e5f

drivers/net/usb/cdc_ncm.c

+2 −2
Original line number Diff line number Diff line
@@ -86,8 +86,8 @@ static u8 cdc_ncm_setup(struct usbnet *dev) 
			      0, iface_no, &ncm_parm,

			      sizeof(ncm_parm));

	if (err < 0) {

		dev_dbg(&dev->intf->dev, "failed GET_NTB_PARAMETERS\n");

		return 1;

		dev_err(&dev->intf->dev, "failed GET_NTB_PARAMETERS\n");

		return err; /* GET_NTB_PARAMETERS is required */

	}



	/* read correct set of parameters according to device mode */