Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59e6ec3d authored by Bart Van Assche's avatar Bart Van Assche Committed by Sasha Levin
Browse files

IB/cma: Fix a race condition in iboe_addr_get_sgid() 



[ Upstream commit fba332b079029c2f4f7e84c1c1cd8e3867310c90 ]

Code that dereferences the struct net_device ip_ptr member must be
protected with an in_dev_get() / in_dev_put() pair. Hence insert
calls to these functions.

Fixes: commit 7b85627b ("IB/cma: IBoE (RoCE) IP-based GID addressing")
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: default avatarMoni Shoua <monis@mellanox.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Roland Dreier <roland@purestorage.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
parent c318c814

include/rdma/ib_addr.h

+4 −2
Original line number Diff line number Diff line
@@ -184,10 +184,12 @@ static inline void iboe_addr_get_sgid(struct rdma_dev_addr *dev_addr, 


	dev = dev_get_by_index(&init_net, dev_addr->bound_dev_if);

	if (dev) {

		ip4 = (struct in_device *)dev->ip_ptr;

		if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address)

		ip4 = in_dev_get(dev);

		if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address) {

			ipv6_addr_set_v4mapped(ip4->ifa_list->ifa_address,

					       (struct in6_addr *)gid);

			in_dev_put(ip4);

		}

		dev_put(dev);

	}

}